vinyl: fix index build crash on invalid UPSERT #10027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
UPDATE
,UPSERT
must not modify primary key parts. UnlikeUPDATE
, such an invalidUPSERT
statement doesn't fail (raise an error) - we just log the error and ignore the statement. The problem is, we don't cleartxn_stmt
. As a result, if we're currently building a new index, theon_replace
trigger installed by the build procedure will try to process this statement, triggering the assertion in the transaction manager that doesn't expect any statements in a secondary index without the corresponding statement in the primary index:Let's fix this by clearing the
txn_stmt
corresponding to a skippedUPSERT
.Note, this also means that
on_replace
triggers installed by the user won't run on invalidUPSERT
(hencetest/vinyl/on_replace.result
update), but this is consistent with the memtx engine, which doesn't run them in this case, either.Closes #10026