Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping events subject to wrapping by wrap-recv-evs? #437

Open
ptaoussanis opened this issue Sep 5, 2023 · 0 comments
Open

Ping events subject to wrapping by wrap-recv-evs? #437

ptaoussanis opened this issue Sep 5, 2023 · 0 comments
Assignees
@ptaoussanis
Labels
bug?

Comments

@ptaoussanis
Copy link
Member

ptaoussanis commented Sep 5, 2023 •
edited

Bug in v1.19.2: wrap-recv-evs? option seems to unintentionally wrap pings when enabled.

Ref. #436 (comment)

Update: actually need to properly consider what behaviour makes the most sense here.
@ptaoussanis ptaoussanis added the bug label Sep 5, 2023
@ptaoussanis ptaoussanis self-assigned this Sep 5, 2023
@ptaoussanis ptaoussanis added bug? and removed bug labels Sep 5, 2023
ptaoussanis added a commit that referenced this issue Sep 5, 2023
@ptaoussanis
[mod] [#437] Don't wrap client-side pings (evaluate)
50a93c8 
Requires further review.

This is a minor but potentially BREAKING change.
Zero urgency, consider holding till next breaking set.

Before this commit:

  Client-side `[:chsk/ws-ping]` events are wrapped to
  `[:chsk/recv [:chsk/ws-ping]]` when `wrap-recv-evs?` is true.

After this commit:

  Client-side `[:chsk/ws-ping` events are NOT wrapped, even
  when `wrap-recv-evs?` is true.

MOTIVATION:

  While `:chsk/ping` is indeed pushed from server, `:chsk/recv` is
  in practice reserved for user-level events. Keeping it that way
  may be better (more convenient for users).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptaoussanis ptaoussanis

Labels
bug?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ptaoussanis