Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Banners to Storybook #1243

Open
Traxmaxx opened this issue Nov 27, 2023 · 4 comments
Open

Add Banners to Storybook #1243

Traxmaxx opened this issue Nov 27, 2023 · 4 comments
Assignees

Comments

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Nov 27, 2023

Add Banners to Storybook so they are properly documented!

Screenshot 2023-11-27 at 13 10 26

https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=1872-12554&mode=dev

You will find a short intro into our Storybook setup in the Dashboard README

@knav33n
Copy link
Contributor

knav33n commented Dec 13, 2023

Hello, could you kindly assign the issue to me?

@AllieMendes
Copy link
Collaborator

Hey @knav33n! The issue has been assigned, I'll give you access to the Design System on Figma
Let me know if you have any questions!

@knav33n
Copy link
Contributor

knav33n commented Jan 13, 2024

Hey @Traxmaxx and @AllieMendes. In Figma, the description suggests that this component is generic, which it doesn't seem to be. I just wanted to clarify whether it is intended to be a generic component or not. Could you also please let me know if everything looks okay? If so, I will proceed to raise a pull request.

komiser-1243

@AllieMendes
Copy link
Collaborator

Hi @knav33n! Yes, the component should be fairly generic, so that the copy and button inside can be changed, along with the color.
So in this case, I would say the Komiser stars button should be a component used inside the banner — the banner shouldn't be just for the Komiser stars use case.
Let me know if this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants