-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERROR! Directory import is not supported resolving ES modules imported #58
Comments
As explained, this blueprint requires some changes in generator-jhipster, for it to work you need to "npm link generator-jhipster" with generator-jhipster matching the provided commit |
The provided commit has conflicts that must be resolved. That is not an acceptable solution, to rely on a problematic commit to jhipster?!? |
@naris you can rebase and fix the blueprint if you want. Jhipster has tens of commits everyday creating tons of conflict with my PR, I am not relying on the PR and enable /unwilling to rebase it everyday. I am using my own branch: https://github.com/yelhouti/generator-jhipster/tree/composite-key |
I will see if I can fix this. However, the error message (Directory import is not supported) is indicative of incorrect code and not a version mismatch somewhere that needs a newer version of jhipster. |
It is turning out to be really problematic to rely on a specific version of jhipster as jhipster upgrade installs jhipster and the blueprints from npm when it runs. I am continuing to work on this but it is definitely problematic :( |
I managed to comment out the code in jhipster that installs jhipster and any blueprints and fixed the issue by editing the files blueprint in node_modules in the project I was trying to upgrade. All that needed to be done is to add "/index.js" to 3 import statements in 3 files: generator-jhipster-primeng-blueprint\generators\client\generator.mjs:
generator-jhipster-primeng-blueprint\generators\entity-client\generator.mjs:
generator-jhipster-primeng-blueprint\generators\entity-i18n\generator.mjs:
After those 3 lines are changed, the update commands works with the released version of jhipster without having to use any particular version of jhipster (such as https://github.com/yelhouti/generator-jhipster/tree/composite-key) or jhipster/generator-jhipster#19849 I will work on forking this project, making the changes and a pull request for it tomorrow |
Here is the output of the successful upgrade:
|
Attempting up upgrade to the just released 7.9.3 version of the latest generator-jhipster-primeng-blueprint:
this error occurred:
The text was updated successfully, but these errors were encountered: