-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(config): input types loose out on provided graphQL documentation #1625
Comments
/bounty 10$ |
💎 $10 bounty • Tailcall Inc.Steps to solve:
🙏 Thank you for contributing to tailcallhq/tailcall!
|
/attempt
|
cancelling my attempt.. I am busy with some other work. For anyone who wants to attempt: convert: TypeKind::InputObject(input_object_type) => {
to_input_object(input_object_type, &type_definition.node.directives).some()
} to
and the new function should look like: fn to_input_object(
input_object_type: InputObjectType,
description: &Option<Positioned<String>>,
directives: &[Positioned<ConstDirective>],
) -> Valid<config::Type, String> {
to_input_object_fields(&input_object_type.fields)
.fuse(Protected::from_directives(directives.iter()))
.map(|(fields, protected)| {
let doc = description.to_owned().map(|pos| pos.node);
config::Type { fields, protected, doc, ..Default::default() }
})
} now you just need to make sure it's passed to blueprint and write the tests as described in issue. |
/attempt Options |
@LED-0102: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
/attempt #1625 Options |
@tusharmath I made the PR based on the suggestions above: #1625 (comment). |
/attempt #1625 Options |
💡 @emekaokoli19 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
🎉🎈 @emekaokoli19 has been awarded $10! 🎈🎊 |
Documentation isn't copied into the blueprint for input types from configurations. For eg:
While using a configuration with an input type like the above, documentation isn't copied in the final schema.
Technical Requirements
The text was updated successfully, but these errors were encountered: