Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc): preserve comments from protobuf to config when generating config #1913

Closed
meskill opened this issue May 10, 2024 · 6 comments · Fixed by #2023
Closed

feat(grpc): preserve comments from protobuf to config when generating config #1913

meskill opened this issue May 10, 2024 · 6 comments · Fixed by #2023

Comments

@meskill
Copy link
Contributor

meskill commented May 10, 2024

For generate command when input is protobuf, comments should be preserved in the output config.

To do this for every entity in input file if it has comment add description string with its content to output config type.

Based on RFC

@meskill
Copy link
Contributor Author

meskill commented May 22, 2024

@tusharmath
Copy link
Contributor

/bounty 200$

Copy link

algora-pbc bot commented May 24, 2024

💎 $200 bounty • Tailcall Inc.

Steps to solve:

  1. Start working: Comment /attempt #1913 with your implementation plan
  2. Submit work: Create a pull request including /claim #1913 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Additional opportunities:

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.

Attempt Started (GMT+0) Solution
🟢 @mehulmathur16 May 25, 2024, 9:16:35 AM #2023

@mehulmathur16
Copy link
Contributor

mehulmathur16 commented May 25, 2024

/attempt #1913

Algora profile Completed bounties Tech Active attempts Options
@mehulmathur16    11 tailcallhq bounties
+ 8 bounties from 4 projects
TypeScript, Rust,
HTML & more
Cancel attempt

Copy link

algora-pbc bot commented May 25, 2024

💡 @mehulmathur16 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented May 31, 2024

🎉🎈 @mehulmathur16 has been awarded $200! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants