Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bugs about "func sym_eig2x2" #8499

Open
xiaolinmu opened this issue Mar 28, 2024 · 1 comment
Open

some bugs about "func sym_eig2x2" #8499

xiaolinmu opened this issue Mar 28, 2024 · 1 comment

Comments

@xiaolinmu
Copy link

In func sym_eig2x2, lambda1 and lambda2 should be modified, i.e., lambda1 = (tr + ti.sqrt(ti.abs(gap))) * 0.5, lambda2 = (tr - ti.sqrt(ti.abs(gap))) * 0.5;In " all(A1 == ti.Matrix.zero(dt, 2, 2)) and all(A1 == ti.Matrix.zero(dt, 2, 2))", the second A1 should be A2; In the following v1 and v2 , normalized() may be singular value, like Matrix, [[1,0],[0,0]], it should be rewrited.

@xiaolinmu
Copy link
Author

In func, "ops" can be used to replace "ti", because in my own code, i use "ti" to replace "ops".

@xiaolinmu xiaolinmu changed the title some bug about "func sym_eig2x2" some bugs about "func sym_eig2x2" Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant