Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

How should we handle CSS styling #5

Open
Nilpo opened this issue Jun 4, 2018 · 5 comments
Open

How should we handle CSS styling #5

Nilpo opened this issue Jun 4, 2018 · 5 comments
Labels
question Further information is requested

Comments

@Nilpo
Copy link
Contributor

Nilpo commented Jun 4, 2018

How would you like to handle styling? The "Vue way" to do this is to take all of the styles necessary for a particular component and place it in with that component. Alternatively, we could keep all styles in a central stylesheet or some mix of both.

I would suggest that resets and page-wide styles are in a central stylesheet and component-specific styles remain with those components.

@Nilpo Nilpo added the question Further information is requested label Jun 4, 2018
@chrisbbreuer
Copy link

What's the point of that? Why would you not just piggyback off of tabler's stylesheets?

@Nilpo
Copy link
Contributor Author

Nilpo commented Jun 4, 2018

It would be using tabler's stylesheet, but it would be sectioned and included with each component. The Vue best practice is to use modular, scoped styles with each component. It would require more work to maintain though which is why I'm asking for opinions.

@chrisbbreuer
Copy link

I get where you are coming from, but I think it's pretty easy to add and remove component .scss files from dashboard.scss. It will make things much easier to maintain and structure - in my opinion.

@isneezy
Copy link
Contributor

isneezy commented Jun 4, 2018

If we have scoped style the end user will have the advantage of just importing the styles that a necessary and not whole tabler dashboard, and this will help them minimise the size of the final bundle. But in another hand we may have maintenance nightmare!
I think for now we can keep the dashboard.scss

@Nilpo
Copy link
Contributor Author

Nilpo commented Jun 4, 2018

Ok, let's keep the single file for the first full release. We can revisit this idea later if we want to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants