ModPack's View Mods in Mod Browser inconsistent

[JavidPack]

Version

Latest 1.4.4-stable

OS

Windows

Platform

Steam

This bug affects...

Mod capability as a Modder

Description

The mods shown by pressing "View Mods in Mod Browser" are only the mods contained in install.txt. install.txt is only populated by workshop ids of mods currently loaded that are loaded from the workshop, so having a modpack enabled or loading a locally installed mod will exclude those mods from the listing when the modpack is saved.

The code for legacy modpacks just checks the mod names directly.

Additionally, if 0 mods are in install.txt, the filter doesn't work at all and all mods are shown.

I'm not sure why some mods are excluded from install.txt, I think it is used for multiple purposes so changing how it is populated might have side effects for the manage-tModLoaderServer scripts. Fixing this will require making sure servers still can use install.txt correctly.

If the intended use-case is for a modpack to be copied from one user to another, I'm not sure why only workshop mods from the original user would be in install.txt when all the mods contained within are "frozen" in the first place and present as .tmod files already.

This behavior might have changed with the recent mod load rework. In any case, it requires some thought.

Log File

No response

Steps to reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Reproduction frequency

No response

Additional Information

No response

[Chicken-Bones]

Modpacks in general need some thorough user focused redesign. It's hard to fix bugs in them at the moment because it's unclear what use cases they're meant to satisfy. I think there's a discussion thread in Discord.

Off the top of my head, I recall:

• Switching between sets of enabled mods for different worlds/playthroughs
• Setting up a dedicated server
• Sharing a mod pack with a friend
• Freezing mod versions (to mitigate risk of playthrough breakage on monthly rollover)
  • I believe this was meant to go hand-in-hand with the ability to manually install old tML releases, and setup fully separate instances. I think this is under-publicized/utilized and probably better implemented another way.