Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible whip effect check #4148

Open
Polaritz opened this issue Apr 3, 2024 · 2 comments
Open

flexible whip effect check #4148

Polaritz opened this issue Apr 3, 2024 · 2 comments
Labels
NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Requestor-Modders Issues or PRs adding or fixing TML modder API Type: Change/Feature Request Is a request for changes to code base in order to provide improved capabilities

Comments

@Polaritz
Copy link

Polaritz commented Apr 3, 2024

Do you intend to personally contribute/program this feature?

No

I would like to see this change made to improve my experience with

Mod capability as a Modder

Description

a new public attribute that projectiles inherit that checks whether the projectile grants whip effect

What does this proposal attempt to solve or improve?

as far as i checked, whip effects checks 2 conditions;
Projectile.minion == true or ProjectileID.Sets.Minionshot[] == true
if modded minion uses preexisting projectile from vanilla or modded one that do not include those conditions(e.g. any bullet), it is not possible to manually apply whip effect on them

Which (other) solutions should be considered?

Add a condition like bool Projectile.grantsWhipEffect or something to track whip effect in real time

@Polaritz Polaritz added NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Type: Change/Feature Request Is a request for changes to code base in order to provide improved capabilities labels Apr 3, 2024
@github-actions github-actions bot added the Requestor-Modders Issues or PRs adding or fixing TML modder API label Apr 3, 2024
@lucasgames8957
Copy link

So, if i am reading this correct, you want the whip the make an effect in real time?

@Polaritz
Copy link
Author

Polaritz commented Apr 3, 2024

So, if i am reading this correct, you want the whip the make an effect in real time?

yes, by adding an public attribute that checks whip effect, like how modder easily changes pre-existing projectile's damage class by using Main.projectile[p].DamageType = ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Requestor-Modders Issues or PRs adding or fixing TML modder API Type: Change/Feature Request Is a request for changes to code base in order to provide improved capabilities
Projects
None yet
Development

No branches or pull requests

2 participants