Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putting the env validation in the config directory #385

Closed
BrightonMboya opened this issue Jun 2, 2023 · 1 comment
Closed

Putting the env validation in the config directory #385

BrightonMboya opened this issue Jun 2, 2023 · 1 comment

Comments

@BrightonMboya
Copy link
Contributor

The current env validation is under packages/auth directory which is not that much intuitive. It is better if it was under packages/config directory or other more intuitive directory.
@amirfakhrullah amirfakhrullah mentioned this issue Jun 4, 2023
Open
@juliusmarminge
Copy link
Member

Tracking this in #397.

I don't want a config package for env variables. The optimal solution is to keep the packages pure and only have envs in the apps

@juliusmarminge juliusmarminge closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliusmarminge @BrightonMboya