-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle GOAWAY
Frame
#89
Comments
This was referenced Oct 27, 2022
1 task
Any ETA when it's going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
http2-wrapper
agent instantiates a newClientHttp2Session
with http2.connect in the Agent class. After this session is created a listener is attached for theerror
event here and theclose
event here.However, there is no listener for the
goaway
event. Since there is no handler to remove sessions which they will continue to be used by subsequent requests. This will then lead to theNew streams cannot be created after receiving a GOAWAY
error being thrown because the session that received theGOAWAY
has not been not removed from the map of available sessions.See https://github.com/nodejs/node/blob/v16.x/lib/internal/http2/core.js#L1166
Related to sindresorhus/got#2156
The text was updated successfully, but these errors were encountered: