Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to Lib_INI_IO.f90 #16

Open
AnnanFay opened this issue May 4, 2020 · 5 comments
Open

References to Lib_INI_IO.f90 #16

AnnanFay opened this issue May 4, 2020 · 5 comments
Assignees

Comments

@AnnanFay
Copy link

AnnanFay commented May 4, 2020

The repeat references in the wiki and README to Lib_INI_IO.f90 are wrong?

I spent a several hours thinking it was my build environment, trying both cmake and FoBiS, before I started digging around the code and found the test cases look nothing like the example usage information.

I'm very unfamiliar with Fortran and cmake so might just be me misunderstanding. I've got it to finally compile by using use finer instead of use Lib_INI_IO.

Hopefully this will help someone else save some time until the docs are updated.

@szaghi
Copy link
Owner

szaghi commented May 4, 2020

@AnnanFay

Dear Anna, I am very sorry, as you noted the docs is not updated. I hope to find the time to update it soon.

Cheers

@szaghi szaghi self-assigned this May 4, 2020
@AnnanFay
Copy link
Author

AnnanFay commented May 4, 2020

Thanks! I managed to correctly compile, link and use the library.

Only thing I noticed which was odd is that non-semicolon comments don't work. finer_backend.f90 suggests that !, ; and # should all work as comment characters however in practice only ; seems to work.

@szaghi
Copy link
Owner

szaghi commented May 5, 2020

Thanks! I managed to correctly compile, link and use the library.

Only thing I noticed which was odd is that non-semicolon comments don't work. finer_backend.f90 suggests that !, ; and # should all work as comment characters however in practice only ; seems to work.

This is a new feature to be added, I was lazy and I supported only semicolon comments. I have to add support for also other markers.

@AnnanFay can you open a new issue for the new comments markers? Issues help me a lot to control the work to be done.

Cheers

@szaghi
Copy link
Owner

szaghi commented May 5, 2020

@AnnanFay the readme has been updated.

Soon I'll try to add support for other comments markers

@szaghi
Copy link
Owner

szaghi commented May 5, 2020

@AnnanFay

Hi, I erroneously assumed that you was asking for new comments marks for inline comments, not for the comments alone. I have modified the parser test to check if !#; work as line comment marker and it seems so. Can you provide a minimal working example showing that ! and # do not work?

For inline comments I have left ; as the only marker for now.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants