Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate params and body #67

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Separate params and body #67

wants to merge 8 commits into from

Conversation

olaven
Copy link
Contributor

@olaven olaven commented Apr 18, 2020 •
edited

Closes #64

WIP -> as this would potentially be a quite big change, I'll test it some more.

@olaven
Copy link
Contributor Author

olaven commented Apr 18, 2020 •
edited

Sorry about those last commits. I did not realize that 0.40.0-libs were used when running make test.

Anyways, I have tested the implementation in a local project and it seems to work as I intended.
@syumai What do you think? 😄

@syumai
Copy link
Owner

syumai commented May 3, 2020

Sorry for the delay in replying. I'll check this later. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate params and http body to avoid confusion
2 participants
@olaven @syumai