-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate params and http body to avoid confusion #64
Comments
Are there any changes nececcary for the PR for this to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! Again: thanks for this project 馃槃
I am wondering if it would make more sense to separate the HTTP response body from
params
, inContext
. This makes the code more explicit and readable, in my opinion. For example:Furthermore, this may cause ambiguity as to what data belongs to URL params and what data belongs to the HTTP body. Consider this (somewhat contrived) example:
I implemented a solution here. If you're interested, I'll submit a PR 馃槃
However, I believe this breaks with Sinatra, so it's completely reasonable to dissagree.
What do you think?
EDIT: typo and added link to implementation
The text was updated successfully, but these errors were encountered: