Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest icon asset src #1077

Open
zirho opened this issue May 11, 2019 · 2 comments
Open

Manifest icon asset src #1077

zirho opened this issue May 11, 2019 · 2 comments
Labels

Comments

@zirho
Copy link
Contributor

zirho commented May 11, 2019

Shouldn't the icon src be hashed in manifest.xjson?

https://github.com/sysgears/apollo-universal-starter-kit/blob/master/modules/favicon/common/assets/manifest.xjson#L5

It seems broken to me in the example heroku site
https://apollo-universal-starter-kit.herokuapp.com/

image

This is what is expected.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://apollo-universal-starter-kit.herokuapp.com/

  2. navigate to Manifest tab in chrome debugging tool
    https://developers.google.com/web/fundamentals/web-app-manifest/

  3. see empty icon section.

@larixer larixer added the bug label May 13, 2019
@larixer
Copy link
Member

larixer commented May 13, 2019

@zirho I think to fix this issue we should use val-loader:
https://github.com/webpack-contrib/val-loader

@beingtmk
Copy link
Contributor

@larixer, How do you suggest doing it with val-loader?

Can we fix it by not hashing it for now, like it is done with favicon.ico?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants