Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test whether conditions are set #943

Open
1 of 3 tasks
janiskemper opened this issue Sep 21, 2023 · 7 comments · Fixed by #996 · May be fixed by #1010
Open
1 of 3 tasks

Test whether conditions are set #943

janiskemper opened this issue Sep 21, 2023 · 7 comments · Fixed by #996 · May be fixed by #1010
Assignees

Comments

@janiskemper
Copy link
Contributor

janiskemper commented Sep 21, 2023

Tasks:

@janiskemper
Copy link
Contributor Author

I believe that we have not thought about which other conditions we might not have tested. I re-open until that list is done!

@janiskemper janiskemper reopened this Oct 16, 2023
@aniruddha2000
Copy link
Contributor

aniruddha2000 commented Oct 18, 2023

@janiskemper
Copy link
Contributor Author

@aniruddha2000 would you say that we have implemented all important ones now?

@aniruddha2000
Copy link
Contributor

#1010 is in progress and i was fixing the mocks IIRC

@batistein
Copy link
Contributor

@aniruddha2000 what is the status here?

@janiskemper
Copy link
Contributor Author

@aniruddha2000 ?

@aniruddha2000
Copy link
Contributor

@janiskemper @batistein Ahh sorry I missed that, I need some time to focus on #1010 as that PR is quite big and I have to recap what I did as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment