Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Remove C assert #425

Open
syoyo opened this issue Jun 7, 2023 · 1 comment
Open

[TODO] Remove C assert #425

syoyo opened this issue Jun 7, 2023 · 1 comment

Comments

@syoyo
Copy link
Owner

syoyo commented Jun 7, 2023

Describe the issue

tinygltf has some C assert, which is not recommended to run tinygltf in secure environment.
(e.g. read malcious glTF file in a server)

Removing assert recommended.

To Reproduce

  • OS : Any
  • Compiler, compiler version, compile options: Any
  • Please attach minimal and reproducible .glTF file if you got an issue related to .glTF data : N/A

Expected behaviour

No assert in tiny_gltf.h.
(Raise an C++ exception when TINYGLTF_NOEXCEPTION is not set(an app is compiled with C++ exception enabled))

Screenshots

N/A

Additional context

N/A

@syoyo
Copy link
Owner Author

syoyo commented Jun 7, 2023

Prepared remove-assert branch: https://github.com/syoyo/tinygltf/tree/remove-assert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant