Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version json.hpp #293

Open
nikita1prasolov opened this issue Oct 17, 2020 · 2 comments
Open

Old version json.hpp #293

nikita1prasolov opened this issue Oct 17, 2020 · 2 comments

Comments

@nikita1prasolov
Copy link

Describe the issue
You have use old version of nlohmann/json - 3.5.0, feature request - switch to latest version 3.9.1

To Reproduce

  • OS - all supported
  • Compiler, compiler version, compile options - all supported
  • Please attach minimal and reproducible .glTF file if you got an issue related to .glTF data - not applicable

Expected behaviour
Users can use improved and addition functionaliies

Screenshots

  • not applicable

Additional context
Best regards, your user, Kit!

@syoyo
Copy link
Owner

syoyo commented Oct 17, 2020

You can use your own json.hpp with TINYGLTF_NO_INCLUDE_JSON ifdef: https://github.com/syoyo/tinygltf#compile-options

Currently there should be no issues using current json.hpp in TinyGLTF, so there isn't strong reason to update it.
We would only accept upgrading json.hpp if it gives faster C++ compilation time than the old version.

PR with benchmarks(C++ compile time) is welcome!

@nikita1prasolov
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants