Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Layer" button to toolbar? #1139

Open
morevnaproject opened this issue Feb 1, 2020 · 20 comments · May be fixed by #3282
Open

"Add Layer" button to toolbar? #1139

morevnaproject opened this issue Feb 1, 2020 · 20 comments · May be fixed by #3282

Comments

@morevnaproject
Copy link
Member

morevnaproject commented Feb 1, 2020

Thanks to @rodolforg, we now have "Add Layer" button in "Layers Panel" -
new_layer

But I found that users are generally didn't notice it there. How about to add one more "Add Layer" button to Toolbox? ^__^

screenshot_005

I believe there it will be very easy to notice.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@michiboo
Copy link

michiboo commented Feb 2, 2020

Hi Could I have a go at this issue?

@ankit-kumar-dwivedi
Copy link
Member

Sure @michiboo ! I'm assigning you this one.

@michiboo
Copy link

michiboo commented Feb 3, 2020

@ankit-kumar-dwivedi is there any past commit that are useful for this task?

@rodolforg
Copy link
Contributor

Check #947 .
And look for dock toolbox too.

@michiboo
Copy link

michiboo commented Feb 3, 2020

@rodolforg Ok thanks!

@michiboo
Copy link

Hi I have added a tool button for add layer to the tool bar, but it doesn't do anything. I added without create state_.cpp file, it is possible to work withpout state_.cpp file?

@morevnaproject
Copy link
Member Author

@michiboo Can you please push your code to your repo, so we can take a look? ^__^

@michiboo
Copy link

@morevnaproject Hi I have push the code to my repo in branch add_layer_tooltip thanks!

@morevnaproject
Copy link
Member Author

Apologies for delay. Please see my comment here - https://github.com/michiboo/synfig/commit/13f2714602edadd9504b06fb8eb65289ca340440#r37690018

@ankit-kumar-dwivedi
Copy link
Member

@michiboo are you still working on this one? need any help/hint?

@Harish-1511
Copy link

@rodolforg
hello sir can i solve the problem

@ice0
Copy link
Collaborator

ice0 commented Jun 23, 2022

Hi, @harish911!
Sure.

@Harish-1511
Copy link

Harish-1511 commented Jun 26, 2022

@ice0
hello sir

what is meaning of this line
build stopped: subcommand failed.
I am using the following commands to build:
./2-build-msys-cmake.sh Debug

can you explain this problem
and how to solve the problem

@ice0
Copy link
Collaborator

ice0 commented Jun 27, 2022

@harish911

Can you show more log lines showing the error?

@Harish-1511
Copy link

where is the code of toolbox panel icons

@ice0
Copy link
Collaborator

ice0 commented Jul 2, 2022

where is the code of toolbox panel icons

Please check dock_toolbox.h/cpp

@neesaaa
Copy link
Contributor

neesaaa commented Nov 22, 2023

if it is still a problem i could give it a shot, i read some files but i am new to open source ,i just need to check some points.
-Does the add_layer function that already exists to add layer is in Canvasview class?

@ice0
Copy link
Collaborator

ice0 commented Nov 23, 2023

if it is still a problem i could give it a shot, i read some files but i am new to open source ,i just need to check some points. -Does the add_layer function that already exists to add layer is in Canvasview class?

Yes. CanvasView::add_layer(String x) is what you are looking for.
Also you can check this PR for more details how this can be implemented: #947

neesaaa added a commit to neesaaa/synfig that referenced this issue Nov 26, 2023
This commit addresses the issue synfig#1139, where users were not noticing the "Add Layer" button in the "Layers Panel." The "Add Layer" button has been added to the Toolbox for better visibility.
Fixes synfig#1139
@neesaaa neesaaa linked a pull request Nov 26, 2023 that will close this issue
@neesaaa
Copy link
Contributor

neesaaa commented Nov 26, 2023

done sorry for the delay

@ice0
Copy link
Collaborator

ice0 commented Dec 4, 2023

done sorry for the delay

Thank you so much for your contribution!

neesaaa added a commit to neesaaa/synfig that referenced this issue Dec 4, 2023
neesaaa added a commit to neesaaa/synfig that referenced this issue Dec 4, 2023
neesaaa added a commit to neesaaa/synfig that referenced this issue Dec 9, 2023
    butter descriptive name for the function ,and erased the empty lines
fix synfig#1139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants