-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Make:Listener] Improve event name matching #1410
Comments
@weaverryan What do you think of this idea ? I started some work on this feature but to list all events, we need to force the declaration of all the classes that extend the Maybe just matching on the built-in events (that we can access from the event registry) would be enough ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When using a class's FQCN as event name, you have to enter the FQCN in the command to make it work.
If the event name given by the user doesn't match a registered event name nor an FQCN, we could try to 'guess' if the input matches a class short name from the
App\\
namespace (we could even sneak some levenshtein in there to catch typos) and ask if the user meant one of the matching results.Do you think that would be doable without ruining the performance (I imagine that on large projects with a lot of classes that could be a rather heavy process) ?
Example
The text was updated successfully, but these errors were encountered: