-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating allowPan or allowZoom props has no effect #72
Comments
Hi Ryan. Indeed, these props were not correctly considered after recent changes and you correctly spotted the issue: event listeners were not updated on props changes. This should be fixed on version Could you confirm it's working as intended on your side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I am trying to use this nice component to allow users to edit a large SVG. However, I have various edit modes where certain ones are supposed to disable any changes to the current pan or zoom so that they can perform other actions. I figured changing the value of
allowPan
andallowZoom
would be reflected. However, it seems that this doesn't cause any effect.My hunch is that the
useEffect
needs to listallowPan
andallowZoom
(probably also most of the other props too) as dependencies and the event listener functions should be moved to be defined in theuseEffect
? However, I am fairly new to react, so I would appreciate any input you have or if I missed something obvious.See this codesandbox reproduction.
EDIT: I played around with the code and just adding the props to the
useEffect
dependencies seems to make this work, but react exhaustive dependencies recommends to define the handler functions in theuseEffect
as well.The text was updated successfully, but these errors were encountered: