Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to init during bin install #144

Open
calebcartwright opened this issue Feb 2, 2021 · 0 comments
Open

Don't attempt to init during bin install #144

calebcartwright opened this issue Feb 2, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Pull Requests/Assistance welcomed!
Projects
Milestone

Comments

@calebcartwright
Copy link
Member

We've a custom build script that's used to provide a shortcut path for folks that want to make it easy for their users to enable hooks in their local env, and this works by leveraging the internal init function.

That's well and good for the lib cases (added as a dev dep and compiled during a cargo test), but there's no reason to attempt to init when building the bin/cli target (e.g. cargo install rusty-hook)

Should be able to use one of cargo's vars to conditionally run the steps in the build script

https://github.com/swellaby/rusty-hook/blob/master/build.rs

@calebcartwright calebcartwright added help wanted Pull Requests/Assistance welcomed! good first issue Good for newcomers labels Feb 2, 2021
@calebcartwright calebcartwright added this to the 1.0 Release milestone Feb 2, 2021
@calebcartwright calebcartwright added this to To do in 1.0 Release via automation Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Pull Requests/Assistance welcomed!
Projects
1.0 Release
  
To do
Development

No branches or pull requests

1 participant