Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emotion): Add support for css inside functions #304

Merged
merged 3 commits into from
May 17, 2024

Conversation

acharron-hl
Copy link
Contributor

This PR fixes #303

The Change

We new fold children inside of ident expressions.

I've added an additional test case and also updated the critical extractions test that not notably was not performing transforms.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 9588499

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swc/plugin-emotion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 self-assigned this May 17, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 changed the title Add support for css inside functions feat(emotion): Add support for css inside functions May 17, 2024
@kdy1 kdy1 merged commit 016c13b into swc-project:main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Emotion plugin doesn't transform usages inside of callbacks
3 participants