Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue of long press animation of keys #1433

Merged
merged 1 commit into from
May 19, 2024

Conversation

Dhruv-Gaba
Copy link
Contributor

πŸ› οΈ Fixes Issue (#1417)

Closes #1417

πŸ‘¨β€πŸ’» Changes proposed and Brief Description

Solved the issue of long press animation. The keys are now working perfectly fine even on long press and the striking animation disappears when the key is released.

βœ… Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“· Video

Untitled.video.-.Made.with.Clipchamp.1.mp4

Copy link

netlify bot commented May 18, 2024

βœ… Deploy Preview for 30daysofjs ready!

Name Link
πŸ”¨ Latest commit 4e42ed0
πŸ” Latest deploy log https://app.netlify.com/sites/30daysofjs/deploys/6648808cada3d700089c7c71
😎 Deploy Preview https://deploy-preview-1433--30daysofjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swapnilsparsh swapnilsparsh merged commit 0ba6593 into swapnilsparsh:master May 19, 2024
4 checks passed
@swapnilsparsh
Copy link
Owner

@Dhruv-Gaba Thank you for contributing to this repo. Looking forward for more πŸš€

@swapnilsparsh swapnilsparsh added gssoc GirlScript Summer of Code 2024 level1 Easy labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GirlScript Summer of Code 2024 level1 Easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Title here] 01 - Drum kit keys. Unresponsive animation on long press.
2 participants