Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontmatter defaults in _config.yml are not correctly applying to pagination pages #254

Open
UlyssesZh opened this issue Aug 29, 2023 · 0 comments

Comments

@UlyssesZh
Copy link

Frontmatter defaults in _config.yml are not applying to pagination pages. This is because frontmatter defaults rely on Convertible#relative_path:

https://github.com/jekyll/jekyll/blob/d86ba153fe012fbf4c62dc4af9dd73df1f1cfd58/lib/jekyll/convertible.rb#L249-L251

Then, PaginationPage inherits #relative_path from Page, where this method is dependent on @dir:

https://github.com/jekyll/jekyll/blob/d86ba153fe012fbf4c62dc4af9dd73df1f1cfd58/lib/jekyll/page.rb#L143-L146

However, PaginationPage objects have their @dir to be nil, so the path information is wrong when Convertible#to_liquid looks at their frontmatter defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant