Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script tag inside {@html ``} not parsed #463

Closed
2 tasks done
nosovk opened this issue Jan 13, 2024 · 1 comment
Closed
2 tasks done

script tag inside {@html ``} not parsed #463

nosovk opened this issue Jan 13, 2024 · 1 comment

Comments

@nosovk
Copy link

nosovk commented Jan 13, 2024

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.

What version of ESLint are you using?

8.56.0

What version of eslint-plugin-svelte are you using?

2.35.1

What did you do?

Configuration
module.exports = {
	root: true,
	extends: [
		'eslint:recommended',
		'plugin:@typescript-eslint/recommended',
		'plugin:svelte/recommended',
		'prettier'
	],
	parser: '@typescript-eslint/parser',
	plugins: ['@typescript-eslint'],
	parserOptions: {
		sourceType: 'module',
		ecmaVersion: 2020,
		extraFileExtensions: ['.svelte']
	},
	env: {
		browser: true,
		es2020: true,
		node: true
	},
	overrides: [
		{
			files: ['*.svelte'],
			parser: 'svelte-eslint-parser',
			parserOptions: {
				parser: '@typescript-eslint/parser'
			}
		}
	],
	rules: {
		'svelte/no-at-html-tags': 'off'
	}
};

<svelte:head>
	{@html `
	<script>
		(function (w, d, s, l, i) {
			w[l] = w[l] || [];
			w[l].push({ 'gtm.start': new Date().getTime(), event: 'gtm.js' });
			var f = d.getElementsByTagName(s)[0],
				j = d.createElement(s),
				dl = l != 'dataLayer' ? '&l=' + l : '';
			j.async = true;
			j.src = 'https://www.googletagmanager.com/gtm.js?id=' + i + dl;
			f.parentNode.insertBefore(j, f);
		})(window, document, 'script', 'dataLayer', 'GTM-XXX');
	</script>
	`}
</svelte:head>

What did you expect to happen?

I expect that linter will ignore part inside {@html} block

What actually happened?

\GTM\index.svelte
  13:61  error  Parsing error: The script is unterminated

Link to GitHub Repo with Minimal Reproducible Example

https://stackblitz.com/edit/sveltejs-kit-template-default-zguqat

try to run npm run lint in web console to see expected result

Additional comments

it was working before at svelte 3

@baseballyama baseballyama transferred this issue from sveltejs/eslint-plugin-svelte Jan 20, 2024
@ota-meshi
Copy link
Member

duplicate of #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants