-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add codesandbox example #867
base: main
Are you sure you want to change the base?
Conversation
# Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [ ] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
…store (#631) fix #183 # Overview <!-- A clear and concise description of what this pr is about. --> I remove target react v16, v17, unnecessary use-sync-external-store ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
fix #529 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Major Changes - ea1c4ed: feat(react): rename Suspensive defaultOptions -> defaultProps - 78f5bd4: feat(react, react-query): remove deprecated apis - 837ed18: feat(\*): remove target react v16, v17 ## @suspensive/[email protected] ### Major Changes - 78f5bd4: feat(react, react-query): remove deprecated apis - 837ed18: feat(\*): remove target react v16, v17 ### Patch Changes - Updated dependencies [ea1c4ed] - Updated dependencies [78f5bd4] - Updated dependencies [837ed18] - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - 837ed18: feat(\*): remove target react v16, v17 ## @suspensive/[email protected] ### Patch Changes - 837ed18: feat(\*): remove target react v16, v17 ## @suspensive/[email protected] ### Patch Changes - Updated dependencies [ea1c4ed] - Updated dependencies [78f5bd4] - Updated dependencies [837ed18] - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…on correctly like @tanstack/react-query v5 (#401) fix #253 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Major Changes - d06e883: fix(react-query): @suspensive/react-query v2's all naming convention correctly like @tanstack/react-query v5 ### Patch Changes - @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies [d06e883] - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
# Overview <!-- A clear and concise description of what this pr is about. --> I remove ErrorBoundaryGroup.Reset ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Major Changes - 6a3f6f4: feat(react): remove ErrorBoundaryGroup.Reset ## @suspensive/[email protected] ### Patch Changes - Updated dependencies [6a3f6f4] - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies [6a3f6f4] - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Major Changes - [#629](#629) [`73c0cc7`](73c0cc7) Thanks [@manudeli](https://github.com/manudeli)! - fix(react): add getServerSnapShot in syncDevMode ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[[`73c0cc7`](73c0cc7)]: - @suspensive/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## beta #867 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 31 31
Lines 428 428
Branches 98 97 -1
=======================================
Hits 359 359
Misses 61 61
Partials 8 8
|
toss/slash#191 (comment) Check this out please |
Rebase is needed before doing this (#867 (comment)) |
56b8c13
to
d6f0f4e
Compare
Could we do this soon? It doesn't necessarily have to be like react.dev, so it might be a good idea to aim to add playground first. |
Overview
closed #7
Points to discuss
theme
I have selected the theme as
atom dark
.Attach a link to the page that lists the available themes: https://sandpack.codesandbox.io/docs/getting-started/themes
Sandpack Component abstraction
It's hard to use autocomplete in MDX because there is no type inference.
I had a choice between constraining the interface to only accept code, and leaving the interface open to modify whenever needed, and I chose the latter.
Once I get this PR review, I'll look for improvements, fix them, and apply them to all articles in bulk.
PR Checklist