From b1422a330d7b5c9952db841bc4498660ec89d720 Mon Sep 17 00:00:00 2001 From: Steve Larson <9larsons@gmail.com> Date: Wed, 2 Aug 2023 14:13:25 -0500 Subject: [PATCH] :bug: fixed fields autocomplete not working in popup closes https://github.com/TryGhost/Ghost/issues/16960 - replaced iframe by div --- ghost/admin/app/styles/components/koenig.css | 2 +- ghost/admin/app/styles/layouts/whatsnew.css | 2 +- .../core/frontend/apps/amp/lib/views/amp.hbs | 4 +-- .../core/frontend/src/cards/css/bookmark.css | 4 +-- ghost/core/package.json | 6 ++--- .../email-templates/partials/styles-old.hbs | 6 ++--- .../lib/email-templates/partials/styles.hbs | 6 ++--- ghost/email-service/package.json | 2 +- ghost/importer-revue/package.json | 2 +- .../fixtures/basic-cards/css/bookmark.css | 2 +- yarn.lock | 26 +++++++++---------- 11 files changed, 31 insertions(+), 31 deletions(-) diff --git a/ghost/admin/app/styles/components/koenig.css b/ghost/admin/app/styles/components/koenig.css index 6336cca4e098..c9c8803e572c 100644 --- a/ghost/admin/app/styles/components/koenig.css +++ b/ghost/admin/app/styles/components/koenig.css @@ -1272,7 +1272,7 @@ margin-right: 6px; } -.kg-bookmark-publisher { +.kg-bookmark-author { text-overflow: ellipsis; overflow: hidden; max-width: 240px; diff --git a/ghost/admin/app/styles/layouts/whatsnew.css b/ghost/admin/app/styles/layouts/whatsnew.css index 44da196a4eb9..70466eeab809 100644 --- a/ghost/admin/app/styles/layouts/whatsnew.css +++ b/ghost/admin/app/styles/layouts/whatsnew.css @@ -246,7 +246,7 @@ margin: 0 6px; } -.gh-wn-entry .kg-bookmark-publisher { +.gh-wn-entry .kg-bookmark-author { overflow: hidden; line-height: 1.5em; text-overflow: ellipsis; diff --git a/ghost/core/core/frontend/apps/amp/lib/views/amp.hbs b/ghost/core/core/frontend/apps/amp/lib/views/amp.hbs index 062492c834b4..e6c7f9789921 100644 --- a/ghost/core/core/frontend/apps/amp/lib/views/amp.hbs +++ b/ghost/core/core/frontend/apps/amp/lib/views/amp.hbs @@ -385,7 +385,7 @@ } .kg-bookmark-card, - .kg-bookmark-publisher { + .kg-bookmark-author { position: relative; } @@ -475,7 +475,7 @@ overflow: hidden; } - .kg-bookmark-publisher::before { + .kg-bookmark-author::before { content: "•"; margin: 0 .5em; } diff --git a/ghost/core/core/frontend/src/cards/css/bookmark.css b/ghost/core/core/frontend/src/cards/css/bookmark.css index 8b4a190c1807..dac03ec6d984 100644 --- a/ghost/core/core/frontend/src/cards/css/bookmark.css +++ b/ghost/core/core/frontend/src/cards/css/bookmark.css @@ -4,7 +4,7 @@ } .kg-bookmark-card, -.kg-bookmark-publisher { +.kg-bookmark-author { position: relative; width: 100%; } @@ -74,7 +74,7 @@ display: inline; } -.kg-bookmark-publisher { +.kg-bookmark-author { text-overflow: ellipsis; overflow: hidden; max-width: 240px; diff --git a/ghost/core/package.json b/ghost/core/package.json index 603e905c60b9..a67f75825374 100644 --- a/ghost/core/package.json +++ b/ghost/core/package.json @@ -102,9 +102,9 @@ "@tryghost/job-manager": "0.0.0", "@tryghost/kg-card-factory": "4.0.8", "@tryghost/kg-default-atoms": "4.0.1", - "@tryghost/kg-default-cards": "9.1.0", - "@tryghost/kg-default-nodes": "0.1.11", - "@tryghost/kg-lexical-html-renderer": "0.3.7", + "@tryghost/kg-default-cards": "9.1.1", + "@tryghost/kg-default-nodes": "0.1.12", + "@tryghost/kg-lexical-html-renderer": "0.3.8", "@tryghost/kg-mobiledoc-html-renderer": "6.0.8", "@tryghost/limit-service": "1.2.6", "@tryghost/link-redirects": "0.0.0", diff --git a/ghost/email-service/lib/email-templates/partials/styles-old.hbs b/ghost/email-service/lib/email-templates/partials/styles-old.hbs index 7720e559159f..4fda7bf26303 100644 --- a/ghost/email-service/lib/email-templates/partials/styles-old.hbs +++ b/ghost/email-service/lib/email-templates/partials/styles-old.hbs @@ -711,11 +711,11 @@ a[data-flickr-embed] img { display: none; } -.kg-bookmark-author { +.kg-bookmark-publisher { line-height: 1.5em; } -.kg-bookmark-publisher { +.kg-bookmark-author { overflow: hidden; max-width: 240px; line-height: 1.5em; @@ -723,7 +723,7 @@ a[data-flickr-embed] img { white-space: nowrap; } -.kg-bookmark-publisher:before { +.kg-bookmark-author:before { content: "•"; margin: 0 6px; } diff --git a/ghost/email-service/lib/email-templates/partials/styles.hbs b/ghost/email-service/lib/email-templates/partials/styles.hbs index 4c36cd85057b..5b42cb539978 100644 --- a/ghost/email-service/lib/email-templates/partials/styles.hbs +++ b/ghost/email-service/lib/email-templates/partials/styles.hbs @@ -761,11 +761,11 @@ a[data-flickr-embed] img { display: none; } -.kg-bookmark-author { +.kg-bookmark-publisher { line-height: 1.5em; } -.kg-bookmark-publisher { +.kg-bookmark-author { overflow: hidden; max-width: 240px; line-height: 1.5em; @@ -773,7 +773,7 @@ a[data-flickr-embed] img { white-space: nowrap; } -.kg-bookmark-publisher:before { +.kg-bookmark-author:before { content: "•"; margin: 0 6px; } diff --git a/ghost/email-service/package.json b/ghost/email-service/package.json index 2130d56ae3be..67603f42a843 100644 --- a/ghost/email-service/package.json +++ b/ghost/email-service/package.json @@ -29,7 +29,7 @@ "@tryghost/email-events": "0.0.0", "@tryghost/errors": "1.2.24", "@tryghost/html-to-plaintext": "0.0.0", - "@tryghost/kg-default-cards": "9.1.0", + "@tryghost/kg-default-cards": "9.1.1", "@tryghost/logging": "2.4.4", "@tryghost/tpl": "0.1.24", "@tryghost/validator": "0.2.4", diff --git a/ghost/importer-revue/package.json b/ghost/importer-revue/package.json index cc11355cf2be..7745763c873d 100644 --- a/ghost/importer-revue/package.json +++ b/ghost/importer-revue/package.json @@ -22,7 +22,7 @@ }, "dependencies": { "@tryghost/debug": "0.1.24", - "@tryghost/kg-default-cards": "9.1.0", + "@tryghost/kg-default-cards": "9.1.1", "@tryghost/string": "0.2.4", "lodash": "4.17.21", "papaparse": "5.3.2", diff --git a/ghost/minifier/test/fixtures/basic-cards/css/bookmark.css b/ghost/minifier/test/fixtures/basic-cards/css/bookmark.css index 35758bca697a..73cc06f7c2be 100644 --- a/ghost/minifier/test/fixtures/basic-cards/css/bookmark.css +++ b/ghost/minifier/test/fixtures/basic-cards/css/bookmark.css @@ -77,7 +77,7 @@ overflow: hidden; } -.kg-bookmark-publisher::before { +.kg-bookmark-author::before { content: "•"; margin: 0 .5em; } diff --git a/yarn.lock b/yarn.lock index 3eb7d34a79ba..311154109421 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6318,10 +6318,10 @@ resolved "https://registry.yarnpkg.com/@tryghost/kg-default-atoms/-/kg-default-atoms-4.0.1.tgz#31ed16c032d8e76d8933fdb020caceb47a99970c" integrity sha512-zrUnpkVoVUS/M97YGWzQqPimDeWLAJNK6zvgW6YQP1KSWyNkVibJporV0QX+LfpMJoVU9pbGyPa8BZBuHWFgOw== -"@tryghost/kg-default-cards@9.1.0": - version "9.1.0" - resolved "https://registry.yarnpkg.com/@tryghost/kg-default-cards/-/kg-default-cards-9.1.0.tgz#6f0704fecc09e9d73d3e6a2ae47173d70586e262" - integrity sha512-nV1wwRp2um5yaBIDaSAQcgH7a/6rXAVI7sEV2BeGQ1jaGCoMHAFRgNzeietBlTSq2c8a08O9zUoZml0yOmg4uw== +"@tryghost/kg-default-cards@9.1.1": + version "9.1.1" + resolved "https://registry.yarnpkg.com/@tryghost/kg-default-cards/-/kg-default-cards-9.1.1.tgz#edf12a75d1a5ed3f314158da34f19609e1b1bb85" + integrity sha512-K26AECrk2z8Mvt6k6sgVpCTBJ5vSVI+jJZIkkAxmk/XJPrhuo50s6jqBJZWBXlZ/XhoiN1azsbObVAOvPYAkRg== dependencies: "@tryghost/kg-markdown-html-renderer" "^6.0.8" "@tryghost/string" "^0.2.0" @@ -6331,10 +6331,10 @@ lodash "^4.17.21" luxon "^3.0.0" -"@tryghost/kg-default-nodes@0.1.11", "@tryghost/kg-default-nodes@^0.1.11": - version "0.1.11" - resolved "https://registry.yarnpkg.com/@tryghost/kg-default-nodes/-/kg-default-nodes-0.1.11.tgz#7decf3c7b8cd815c8cb59f41e4485b514c9b0f5d" - integrity sha512-EoesMVsPWMugJcsUZS2cNXxNB88qBWVbk/PpUp9ALPOIiqbWypGPEuJvFZGQI5YaAGJl3mtNaNaIkRndnnGtSA== +"@tryghost/kg-default-nodes@0.1.12", "@tryghost/kg-default-nodes@^0.1.12": + version "0.1.12" + resolved "https://registry.yarnpkg.com/@tryghost/kg-default-nodes/-/kg-default-nodes-0.1.12.tgz#41d1ef24b8bde4f5db755248f1bf76b8d3bca436" + integrity sha512-qmdqmp7G/qdrpqvWUx9quOD+8hXll3GWLeA+l3xOIUSYL5d4KKpHvUA3pv0QJcXovFpypC9nwsXPxPjYlCO4pA== dependencies: "@tryghost/kg-clean-basic-html" "^3.0.21" "@tryghost/kg-markdown-html-renderer" "^6.0.8" @@ -6344,10 +6344,10 @@ lodash "^4.17.21" luxon "^3.3.0" -"@tryghost/kg-lexical-html-renderer@0.3.7": - version "0.3.7" - resolved "https://registry.yarnpkg.com/@tryghost/kg-lexical-html-renderer/-/kg-lexical-html-renderer-0.3.7.tgz#1361ce0368a10d90cd3ad8dec3f826ef83d1ba5a" - integrity sha512-zAiXO7VASFVBCuL37Cp7rOSwcb1UlmfoXDIMl/rQQFxBnlbhMrQN9A9T3vWj2Dq7HQhynPuc2dAvT/ogEntRUA== +"@tryghost/kg-lexical-html-renderer@0.3.8": + version "0.3.8" + resolved "https://registry.yarnpkg.com/@tryghost/kg-lexical-html-renderer/-/kg-lexical-html-renderer-0.3.8.tgz#66c55b1f29e62ef18242eeed2c460847ecaeede6" + integrity sha512-f7cgQcLyWRoK54AwP7/bOqzSvuPf0+WplR91TK0GnjUBuIS3qCJ9oMm1uZz36oiRZwda76j7XB/KfPjofpKpbg== dependencies: "@lexical/clipboard" "^0.11.0" "@lexical/code" "^0.11.0" @@ -6355,7 +6355,7 @@ "@lexical/link" "^0.11.0" "@lexical/list" "^0.11.0" "@lexical/rich-text" "^0.11.0" - "@tryghost/kg-default-nodes" "^0.1.11" + "@tryghost/kg-default-nodes" "^0.1.12" jsdom "^22.1.0" lexical "^0.11.0" prettier "^2.7.1"