Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor][Android] Fix image caret failing golden tests #1996

Open
angelosilvestre opened this issue May 13, 2024 · 0 comments
Open

[SuperEditor][Android] Fix image caret failing golden tests #1996

angelosilvestre opened this issue May 13, 2024 · 0 comments
Labels
type_bug Something isn't working

Comments

@angelosilvestre
Copy link
Collaborator

We have two golden tests that are passing locally, but failing on the CI. Regenerating these goldens doesn't produce different golden files. Additionally, using our tools to compare goldens with a pixel tolerance seems to cause the debugNeedsPaint != true assertion failure in these tests.

testGoldensOnAndroid(
'shows caret at right side of an image',
(tester) async {
await _pumpCaretTestApp(tester);
// Tap close to the right edge of the editor to place the caret
// downstream on the image.
await tester.tapAt(
tester.getTopRight(find.byType(SuperEditor)) + const Offset(-20, 20),
);
await tester.pumpAndSettle();
await screenMatchesGolden(tester, 'super-editor-image-caret-downstream-android');
},
// TODO: find out why this test fails on CI only.
skip: true,
);

testGoldensOnAndroid(
'shows caret at left side of an image',
(tester) async {
await _pumpCaretTestApp(tester);
// Tap close to the left edge of the editor to place the caret upstream
// on the image.
await tester.tapAt(
tester.getTopLeft(find.byType(SuperEditor)) + const Offset(20, 20),
);
await tester.pump();
await screenMatchesGolden(tester, 'super-editor-image-caret-upstream-android');
},
// TODO: find out why this test fails on CI only.
skip: true,
);
});

Those tests were skipped to unblock a PR. Find out why this is happening and re-enable these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant