Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using either TLS endpoints or local endpoints but not both #47

Open
mbyczkowski opened this issue Feb 13, 2018 · 1 comment
Open

Comments

@mbyczkowski
Copy link
Contributor

Initially, TLS endpoints started as a secure option for local endpoints (so fully encrypted connection even between local proxy - like nginx) that can be exposed (because of encryption and shared, static port). It seems unnecessarily complex to have wormhole listen on both TLS and dynamic ports opened for each session (so right now always 2 endpoints for each session).

@doodles526 I think we should make it either/or. I know we talked about having a support for both initially, but that constraint is gone. We could just make UseSharedPortForwarding turn off local endpoints. Thoughts?

@doodles526
Copy link
Contributor

Yeah, I agree on that front. Using both at the same time was put there by me mostly as a way to make sure you all could easily transitiong existing connections. If that change is finished on your end I think having one or the ether is a solid decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants