add choose relative weights #6322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telephon
requested changes
May 24, 2024
Asmatzaile
force-pushed
the
choose-weights
branch
from
0e1781b
to
7851c80
Compare
telephon
requested changes
May 24, 2024
Asmatzaile
force-pushed
the
choose-weights
branch
from
7851c80
to
cc0a3af
Compare
|
ok, good – thanks! Now let's wait and see what comes out of https://scsynth.org/t/choosing-how-to-choose-with-self-normalising-weights/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
wchooseandwindexdon't normalize; that makes it easy to get unexpected results. Instead of modifying them and potentially slowing down existing code, an optional argument is added to.choose.Fixes #6311.
Types of changes
To-do list