-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate cherry-picking workflow #5132
Labels
Milestone
Comments
Closed
Closed
I'm pinning the issue for now, since we haven't fully addressed it for the 3.12 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
related to #5129 , automating cherry-picking would save maintainers time, reduce confusion, and simplify the changelog and release processes.
Description of Proposed Feature
i think i've come up with a reasonable workflow. we'd adopt the following workflow:
tools
could be run by any maintainer at any time to generate a cherry-pick PR; permissions to add/remove labels would be necessaryusing labels instead of a project board is mainly a safety step -- right now when you add a PR to a project board by default it goes into a special 'awaiting triage' state, and programmatically querying about the project won't return that PR. there's a risk of someone adding the PR to the board and it never gets noticed or gets noticed too late. presence of a label is a binary state, so there's no such risk.
Plan for Implementation
the script would do the following:
the title and/or text of the PR should be something easily parsed by a script so that we can use it in #5129 .
we should probably also add an 'undo' script that closes the PR and adds back the labels, in case something goes wrong or one of the PRs shouldn't be cherry-picked.
EDIT: forgot to add my notes about how to get associated commits from a PR. i couldn't find a way to do it more easily than this:
The text was updated successfully, but these errors were encountered: