-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Progress Bars #10
Comments
@olirice I would like to work on it. can please point me to contributing guideline for this repo I was find it |
great! we don't have official contributing guidelines Broadly you'll need
setup a virtualenv
install the pre-commit hooks
at that point you should be able to run
and have it pass. Note: on the first run a docker container will be spinning up so it could take a couple minutes. After that It'll be much faster. We have 100% code coverage as a requirement so any new lines/functions must be covered. You can check if what you introduce is covered using
to generate a report, followed by
to see the coverage report all new functions/methods should conform to the current documentation style let me know if you have any trouble |
The lack of feedback during
Collection.upsert
andCollection.create_index
is a bad DX.It would be great to get some progress bars but I haven't been able to get them working properly in notebooks and shell environments.
If anyone has experience adding them this would be a great community contribution
upsert
vecs/src/vecs/collection.py
Line 108 in 87ed2d3
but it can't always assume that
vectors
is sized. Maybe a runtime check to see if*vectors*
has a known length and providing it to the progress bar if known would be bestcreate_index
vecs/src/vecs/collection.py
Lines 346 to 350 in 87ed2d3
this one is a little more involved as it'll have to introduce client side keyset pagination on the
id
primary key to get feedback to pythonThe text was updated successfully, but these errors were encountered: