-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user object warning logged, even when not touching session.user
#888
Comments
Someone having this issue when:
|
It's likely the other two warnings, that I couldn't figure out how they are triggering, are triggered when SvelteKit checks if passed values are POJOs, in certain situations. See #873 (comment) |
Thanks @kangmingtay. I suspect that PR will resolve issues for some people - specifically the ones exclusively experiencing this when calling things like As an aside, how do I test an RC? I added an override in my package.json, and after doing |
@kangmingtay looks like there is something wrong with the build process for RCs. If you checkout the code on npm, you'll see the PR code is not there. |
@j4w8n yeah your analysis is right, any method that implicitly accesses the user property in the session object will trigger the warning log. i think we can implement your suggestion here so the warning is only logged once per proxy session, but will need some time to test this out since we're currently quite tight on bandwidth |
Until this issue is resolved, and perhaps even after that, I've tweaked my demo app - v0.3.0 - to where I no longer receive any warnings. My solution is done in a legitimate way, which checks all of the security boxes. The code in hooks.server.ts verifies the JWT and uses it's decoded data to craft a validated session. This session will pass any internal auth-js checks, as well as type checks. |
I think the suggestion here from @j4w8n is great but I'd also like a way to suppress this warning completely in production build. I don't want this to be logging inside of my application terminal when its being run in production mode. |
## What kind of change does this PR introduce? Bug fix. ## What is the current behavior? A call to `getSession()`, when using server storage, logs a warning every time `session.user` is accessed. This is causing a lot of people to see multiple consecutive logs to the console - especially for SvelteKit users. ## What is the new behavior? Ensures that accessing `session.user`, from a `getSession()` call, only logs the warning once per Proxy session instance. In other words, once per server request. ## Additional context #888
any update? |
* Sveltekit 2 migration! Mostly just running `npx svelte-migrate@latest sveltekit-2` and fixing package conflicts. Use @supabase/auth-helpers-sveltekit to ^0.11 to avoid supabase/auth-js#888
Still logging, try different way to suppress it too, seems nothing works vite, sveltekit |
any update?? |
Bug report
Describe the bug
With [email protected] and the ssr auth helper package, after a user logs in, the below warning is logged to the server console five times, with a fairly minimal SvelteKit app. This happens despite the fact that none of my code is calling
session.user
, nor am I destructuring the user property fromsession
, or destructuring with...rest
-type syntax.Using the user object as returned from supabase.auth.getSession() or from some supabase.auth.onAuthStateChange() events could be insecure! This value comes directly from the storage medium (usually cookies on the server) and many not be authentic. Use supabase.auth.getUser() instead which authenticates the data by contacting the Supabase Auth server.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
https://github.com/j4w8n/getsession-warning
Expected behavior
The warning should not log when dev code doesn't explicitly call
session.user
.Root Cause
I figured out why the first three logs happen: the Supabase client's server-side storage, from +layout.ts, is returning stringified JSON. You can see this in the docs.
JSON.stringify()
causes each property ofsession
to be touched during the stringify process, which inevitably callssession.user
. So, each time_useSession()
is called, whether implicitly through dev code likegetSession()
or explicitly with internal auth-js processes, the warning is being logged.I can't figure out where the final two warning logs are coming from. Could be from the same client initialization as above, but perhaps whatever triggers it is getting run asynchronously, so it's logging later.
Even if this warning wasn't an issue in the context of ssr, it could still be problematic, as the auth-js client itself calls
session.user
when updating a user, setting a session, refreshing a session, and more - at least some of which could theoretically happen server-side.System information
Additional context
#873
#873 (comment)
https://tc39.es/ecma262/multipage/structured-data.html#sec-json.stringify
https://tc39.es/ecma262/multipage/structured-data.html#sec-serializejsonproperty
https://github.com/supabase/auth-js/blob/master/src/GoTrueClient.ts#L1111-L1124
The text was updated successfully, but these errors were encountered: