Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to 5.0 using SwiftPM fails #244

Open
gabors opened this issue Apr 7, 2020 · 5 comments
Open

Migration to 5.0 using SwiftPM fails #244

gabors opened this issue Apr 7, 2020 · 5 comments

Comments

@gabors
Copy link

gabors commented Apr 7, 2020

Second time trying to update my project to v 5.
What a load of hurt.

project never finishes compiling, CPU spinning at 100%

Using only SPM dependencies in the projects, iOS, tvOS and Mac Catalyst.
Xcode 11.4, Swift 5.1

@sunshinejr
Copy link
Owner

Hey @gabors, sorry that you had to go through this issue. Could you check #242 and #239 to see if it helps? There were quite a few changes to the library so you might have missed something. In case you're sure it's not it, we will try to investigate further!

@OIO-WPK
Copy link

OIO-WPK commented Apr 10, 2020

Reporting same experience as @gabors: upgrading from 4.0 brought Xcode to its knees.

Manually updated all static let keys to var, etc. according to the guide but still did not help.

Xcode 11.4, Swift Packages

@sunshinejr
Copy link
Owner

@OIO-WPK did you change fetch/save from Defaults[.key] to Defaults[\.key]?

@OIO-WPK
Copy link

OIO-WPK commented Apr 11, 2020

No, I updated them to Defaults.key(the IMHO cleaner syntax) which did clear the compiler's red flags and made me think it was ok (although compilation as a whole still could not finish).

@OIO-WPK
Copy link

OIO-WPK commented Apr 11, 2020

BTW, thank you for your work, @sunshinejr!

I suspect this could be the issue also, and will try that (access via key path) once i switch back to that 5.0 branch. (Because of the need for Combine support and other packages' dependency, i am currently testing another framework.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants