Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docset installation #59

Open
xeruf opened this issue Feb 2, 2023 · 1 comment
Open

Improve docset installation #59

xeruf opened this issue Feb 2, 2023 · 1 comment

Comments

@xeruf
Copy link

xeruf commented Feb 2, 2023

Great tool, since I prefer the terminal, much better match for me than Zeal :)

But I think the installer could use a few improvements, firstly smart-case search (case-sensitive as soon as there are uppercase-characters):

❯ dasht-docsets-install Rails
--2023-02-02 13:28:55--  https://api.github.com/repos/Kapeli/feeds/git/refs/heads/master
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving api.github.com (api.github.com)... 140.82.121.5
Connecting to api.github.com (api.github.com)|140.82.121.5|:443... connected.
HTTP request sent, awaiting response... 304 Not Modified
File ‘/home/janek/.local/cache/dasht/master’ not modified on server. Omitting download.

--2023-02-02 13:28:55--  https://api.github.com/repos/Kapeli/feeds/git/trees/7a8c0a2e886b4f379111cf55dd8a702ef2e5927e
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving api.github.com (api.github.com)... 140.82.121.5
Connecting to api.github.com (api.github.com)|140.82.121.5|:443... connected.
HTTP request sent, awaiting response... 304 Not Modified
File ‘/home/janek/.local/cache/dasht/7a8c0a2e886b4f379111cf55dd8a702ef2e5927e’ not modified on server. Omitting download.

Installable docsets (6):

        Grails, Ruby_on_Rails_3, Ruby_on_Rails_4, Ruby_on_Rails_5, Ruby_on_Rails_6, Ruby_on_Rails_7

echo Install Grails docset '[y/N]'?...^C%                                                                                    

Furthermore, I do not understand why there is a listing of all files in the docset upon installation.
If you want to show progress, maybe you want something like this: https://code.ftt.gmbh/janek/dotfiles/src/branch/main/.local/bin/scripts/rewrite

@sunaku
Copy link
Owner

sunaku commented Feb 28, 2023

I have implemented a single-line progress indicator (using awk in POSIX fashion) in commit b2e2daf. Please try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants