Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for collision detection unit #352

Open
3 tasks
meganindya opened this issue Jul 4, 2023 · 5 comments · May be fixed by #358
Open
3 tasks

Add unit tests for collision detection unit #352

meganindya opened this issue Jul 4, 2023 · 5 comments · May be fixed by #358
Labels
good first issue Good for newcomers

Comments

@meganindya
Copy link
Member

Add white-box unit tests for:

  • modules/code-builder/src/collision/utils/index.ts
  • modules/code-builder/src/collision/Brute.ts
  • modules/code-builder/src/collision/QuadTree.ts

Create [filename].spec.ts inside modules/code-builder/src/collision/spec folder for each module.
@meganindya meganindya added the good first issue Good for newcomers label Jul 4, 2023
@ShubhamAXS19
Copy link

Heyy
i would like to work on this issue. Please assign it to me.

@meganindya
Copy link
Member Author

Go ahead. Feel free to make a PR. Keep Code Quality Notes in mind :)

ViharGandhi added a commit to ViharGandhi/musicblocks-v4 that referenced this issue Jul 17, 2023
@ViharGandhi
feat: Add white-box unit tests for modules/code-builder/src/collision…
eef81c6 
…/utils/index.ts

Fixes sugarlabs#352

This commit adds white-box unit tests for the module modules/code-builder/src/collision/utils/index.ts. This is the first task out of three tasks related to issue sugarlabs#352.
@ViharGandhi ViharGandhi linked a pull request Jul 17, 2023 that will close this issue
Open
@omsuneri
Copy link

omsuneri commented Oct 8, 2023

can i contribute for this issue ??

@dhruvchandak30
Copy link

@meganindya Is the PR made by Vihar not eligible for merging? May I work on this issue?

@Utkarsh-2005
Copy link

@meganindya can i work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Music Blocks (v4) Code Builder
Status: ⌛️ Ready
Milestone
No milestone
5 participants
@meganindya @ShubhamAXS19 @Utkarsh-2005 @dhruvchandak30 @omsuneri