We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For instance in some places we use el.nodeType which in our abstraction returns a string:
el.nodeType
... getNodeType() { switch(this.el.nodeType) { case window.Node.TEXT_NODE: return "text" case window.Node.ELEMENT_NODE: return 'element' case window.Node.DOCUMENT_NODE: return 'document' case window.Node.COMMENT_NODE: return 'comment' case window.Node.PROCESSING_INSTRUCTION_NODE: return 'directive' case window.Node.CDATA_SECTION_NODE: return 'cdata' default: // } }
We should consider deprecating these problematic native API's and use explicit getters when possible.
E.g. el.isCdataElement() then it is clear this is custom API with different semantics.
el.isCdataElement()
The text was updated successfully, but these errors were encountered:
We may also want to use symbols for representing node types. E.g.
const { CDATA } = DOMElement.NodeTypes
Sorry, something went wrong.
No branches or pull requests
For instance in some places we use
el.nodeType
which in our abstraction returns a string:We should consider deprecating these problematic native API's and use explicit getters when possible.
E.g.
el.isCdataElement()
then it is clear this is custom API with different semantics.The text was updated successfully, but these errors were encountered: