Container annotation and marker index

[Integral]

@oliver---- just a noisy reminder about new container annotation problems.
After new marker manager API was introduced marker index is no longer inherited from document index and we have no container annotation markers inside.
You proposed to deal with container annotations in it's own manager and package.

[obuchtala]

Thx Am 20.06.2017 12:56 vorm. schrieb "Daniel Beilinson" < [email protected]>:

…

@oliver---- <https://github.com/oliver----> just a noisy reminder about new container annotation problems. After new marker manager API was introduced marker index is no longer inherited from document index and we have no container annotation markers inside. You proposed to deal with container annotations in it's own manager and package. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1061>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARVw9ft7Q58xZ09tCuHfW05mdBuB6c9ks5sFu6SgaJpZM4N-12i> .

[Integral]

Just FYI there is #1095 which is it.
However I decided not to move models and index into this package due to number of issues. For instance it is hard to deal with them when it's comes to transaction documents which is cloning document before manager gets connected.
Basically it's your February work plus manager and without topsy-turvy'ish project ;)

[Integral]

I found this implementation of manager a bit naive and with large set of container annotations everything becoming slow. Instead of rerendering whole set of fragment markers we should rerender only those who related to changed text nodes. Working on this.

[obuchtala]

I absolutely agree.

[Integral]

There are still cases which is not handled properly. For instance container annotation didn't got deleted when you use container selection with the annotation inside. Probably we should improve test suite...

[Integral]

@oliver---- would you please be so kind to review the PR? It is still have at least one bug which I'm aware about, but i'm still didn't trace all the circumstances. Your general feedback and code quality review will be very much helpful. There are not too much changes compared to develop brunch. Please!

Sent from my Xiaomi Redmi 3S using FastHub

[Integral]

Ok, that bug also fixed now...

[obuchtala]

Will do