Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for v5 to ease migration to v6 of large ecosystems #4281

Open
Kegulf opened this issue Mar 20, 2024 · 0 comments
Open

Feature request for v5 to ease migration to v6 of large ecosystems #4281

Kegulf opened this issue Mar 20, 2024 · 0 comments

Comments

@Kegulf
Copy link

Kegulf commented Mar 20, 2024

Problem

I work at a company where we have quite a bit of internal open source (code open sourced internally in the company and in use by all teams). We use styled-components for all our styling.

I see an issue after upgrading some of our shared libs to styled v6.
We want to use the named export (code ex) to silence a lint-rule relating to "use named if both named and default exists".
As of now we are not able to use the named export in shared libs as this breaks in SPAs. This is because we are stuck on v5 i SPAs until all "styled-props" are converted to transient props in all shared libs (due to breaking change in v6). Classic chicken egg problem 😅

import { styled } from 'styled-components';

image

Suggested feature

Add the named export of styled to v5 as well. Shouldn't cause any problems that I can think of, and it would make the migration process better, at least for me and my co-workers 😁

If this issue is not handled by anyone else I will submit a PR this weekend when I actually have time 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant