New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing types for confirming "card" payment intents #1285
Comments
@Borales Today we don't have types for card payments as this hash can also take raw card details (like number and CVC) which is strongly discouraged as it has PCI implications (see doc). It agree it'd be helpful to support passing those masterpass details and other related parameters though so we might do this in the future. Tagging as |
@remi-stripe is it an experimental payment method or something? You could still add types for Card type with the |
We could and should! It's just a bit more complex than it appears to be from the outside and so for now we've defaulted to no types for the |
We have been using this package for a long time, but we noticed that some Typescript types are missing, more specifically - confirming the "card" payment intents by following this manual.
Stripe version:
8.186.0
Typescript version:
4.3.5
payment_method_data.type
doesn't acceptcard
as a valid value, and Typescript compilation fails. Up until this point we were using@ts-ignore
comment to skip this call from TS errors, but I'm afraid it may ignore some upcoming changes that we need to be aware of.The text was updated successfully, but these errors were encountered: