New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow public access to ApiRequestParams
subclass constructors/fields
#1393
Labels
Comments
shaun-wild
changed the title
Allow public access to
Allow public access to Jul 18, 2022
ApiRequestParams
child constructorsApiRequestParams
subclass constructors/fields
Side note: An equals method would be super helpful if we're mocking out Stripe in unit tests! |
Thank you for your feature request! It's a pretty large change to the design of the library. We'll have to investigate and assess tradeoffs of this change. We might not be able to get to this soon because of other commitments, marking for the future. |
Thanks for your response, I look forward to any updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I am using Kotlin and the use of the builders provided on these classes is overly verbose.
Describe the solution you'd like
Make the constructors public, so I can build the objects myself, using Kotlin's Type Safe Builders.
Also, I believe the fields will need to be accessible.
Or even create a Kotlin extensions library with the type-safe builders included.
Describe alternatives you've considered
I've tried creating a wrapper around the builders themselves, but it turned out to be extremely cumbersome.
Additional context
For example, instead of:
I could simply do
But I cannot instantiate the classes myself, as the constructors are private.
The text was updated successfully, but these errors were encountered: