Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Tag commits with Stripe API versions #43

Open
kavdev opened this issue Jun 11, 2019 · 3 comments
Open

Request: Tag commits with Stripe API versions #43

kavdev opened this issue Jun 11, 2019 · 3 comments
Labels

Comments

@kavdev
Copy link

kavdev commented Jun 11, 2019

Hi there!

Would it be possible to create tags with stripe api versions (e.g. 2019-05-16)? The dj-stripe library contributors are working on automatically generating fixtures, and we'd love to be able to pull down fixtures/schema by api version.

Best,
Alex

@brandur-stripe
Copy link
Contributor

Hey Alexander,

This should be possible, but we'd need to re-arrange our update scripts somewhat to give the current one access to a GitHub API key that could be used to produce the tag.

A potential problem here for you though is that we're still currently treating the OpenAPI specification as a "forward only" affair. If you look at the repository's history you can get specs for old API versions, but those specs are never updated even though the API version they're tagged under might change as new forwards-compatible API features are added. The effective result is that the only OpenAPI specification that we really guarantee to be accurate is the one under master.

cc @stripe/api-libraries

@kavdev
Copy link
Author

kavdev commented Jun 24, 2019

@brandur-stripe No worries, that'll work for us. Thanks!

@lx-stripe
Copy link

@kavdev I hacked a script to map API versions to spec revisions: table here as well as other endpoints. I'll probably extend this a bit (eg. to support older openapi specs) and host it somewhere else... but in the meanwhile, feel free to tweak it to your needs. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants