Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples needed fixing for legibility and Windows environments #219

Open
replaysMike opened this issue Feb 1, 2022 · 1 comment
Open

Comments

@replaysMike
Copy link
Contributor

replaysMike commented Feb 1, 2022

Bug report

I've added a pull request #218 to fix a few issues with the examples documentation, especially when using on Windows environments. The formatting was also fairly inconsistent, and I feel the updates I did makes it more legible.

Welcome any changes of course.

@replaysMike
Copy link
Contributor Author

I should note, the instructions for running the node server are also incorrect.

cd server/node
# There's a README in this folder with instructions to run the server and how to enable Stripe Tax.
npm install
npm start

The packages.json is in the root folder, and this repo does not include the node/server.js folder/file.

Error: Cannot find module 'C:\tools\checkout-single-subscription\server\node\server.js'  
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)        
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)                   
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47 {                                        
  code: 'MODULE_NOT_FOUND',                                                              
  requireStack: []                                                                       
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant