Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging configuration is never updated for Connect when connector operator is disabled #9986

Open
scholzj opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels

Comments

@scholzj
Copy link
Member

scholzj commented Apr 17, 2024

Currently, when the connector operator (connector resources / strimzi.io/use-connector-resources annotation) is disabled, we never update the logging configuration - neither dynamically nor through a rolling restart. Not doing the dynamic update is likely caused by the following logic:

  • Without the connector operator, users need to manage connectors through REST
  • As users need to manage things through REST we cannot setup network policies for it easily as we would block access to it for the users
  • Without the network policies, we cannot guarantee that we will have access to the REST API for dynamic configuration

This logic makes sense, but not changing the logging configuration at all due to this seems like a major gap that should be addressed. I guess we have several options:

  1. Create the network policy even when the connector operator is disabled and force users to create their own network policies to access the REST API
  2. Ignore the missing network policies and risk the reconciliation error when the networking denies access by default
  3. Have a separate mechanism and roll the pods when logging changes and connector operator is disabled
  4. Ignore it and just document it

(Keep in mind that options 1 and 2 have backward compatibility issues and might break clusters that worked fine until now)

The same logic applies also to the list of available connector plugins. But obviously, that is a lot less serious problem compared to the logging configuration.


I guess in general, we should also think about the future of the connector operator ... I think we have many users using the REST API for one reason or another. So we cannot remove that mode. But should we enable the connector operator by default in our examples? Should we treat the disabled connector operator as a legacy mode we do not prefer and just ignore its limitations (i.e. go with the option 4)? Or do we want to fully support it?

@scholzj
Copy link
Member Author

scholzj commented Apr 18, 2024

Discussed on the community call on 18.4.: We should go with the option 3: Have a separate mechanism and roll the pods when logging changes and connector operator is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant