Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the Helm Chart #9862

Closed
scholzj opened this issue Mar 21, 2024 · 2 comments · Fixed by #10192
Closed

Add unit tests for the Helm Chart #9862

scholzj opened this issue Mar 21, 2024 · 2 comments · Fixed by #10192

Comments

@scholzj
Copy link
Member

scholzj commented Mar 21, 2024

We should try to add some unit tests for our Helm chart - for example using the https://github.com/helm-unittest/helm-unittest project.

@scholzj
Copy link
Member Author

scholzj commented Apr 4, 2024

Triaged on the community call on 4.4.2024: Makes sense and would be a good contribution for someone who knows / uses Helm.

@maciej-tatarski
Copy link
Contributor

Hi @scholzj, I'm thinking about picking it up. I'm just wondering what should be granularity of the test, do we only want to test more complex scenarios when we use some helm functions and such or do we want to test all the functionalities?

Do we want to have it run on PR as well?

I've create this PR, as a conversation starter. If it is ok for you to do it in this way, I can add the rest of the test to it: #10192

Example pipeline/workflow:
https://github.com/strimzi/strimzi-kafka-operator/actions/runs/9366458701/job/25783959894?pr=10192

@scholzj scholzj linked a pull request Jun 4, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants