Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility for dark them palette #147

Open
laicasaane opened this issue Sep 15, 2023 · 3 comments
Open

Improve visibility for dark them palette #147

laicasaane opened this issue Sep 15, 2023 · 3 comments
Labels
design Design matters enhancement New feature or request p4 Low priority, nice to have

Comments

@laicasaane
Copy link

laicasaane commented Sep 15, 2023

For me, texts appears blurry in the current dark palette (especially the "red" color). For example I find it unpleasant reading this screenshot.

image

The red "Blog" word appears too dimmed.

image

@VaclavElias
Copy link
Contributor

Thank you for your feedback. We use Bootstrap 5, with lots of defaults so we have less gears on our side to maintain, including the dark theme functionality.

We had to customise certain things for the dark theme (dark background image, colours, ..), which might not be that appealing at the moment.

The dark theme is an experimental feature on our Stride Web to collect feedback like yours, so thank you for reporting it.

The text shouldn't be blurry as we made no changes there. Any suggestion for the red, what RGB would you suggest?

@VaclavElias VaclavElias added enhancement New feature or request p4 Low priority, nice to have design Design matters labels Sep 15, 2023
@laicasaane
Copy link
Author

laicasaane commented Sep 15, 2023

The text shouldn't be blurry as we made no changes there.

It's blurry in my eyes because of the contrast between colors, not in technical sense though.

Any suggestion for the red, what RGB would you suggest?

I can tell you something to replace the red, however it needs a better dark palette overall. I'll come back with a palette proposal.

@VaclavElias
Copy link
Contributor

VaclavElias commented Sep 15, 2023

Thanks. Current customisation is done here https://github.com/stride3d/stride-website/tree/master/css

And theme selector reused and modified from the Bootstrap 5 website.

https://github.com/stride3d/stride-website/blob/master/assets/scripts/theme-selector.liquid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design matters enhancement New feature or request p4 Low priority, nice to have
Projects
None yet
Development

No branches or pull requests

2 participants