Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer: Track when Friend[] Arrives #9

Open
hnryjms opened this issue Sep 13, 2020 · 2 comments
Open

Peer: Track when Friend[] Arrives #9

hnryjms opened this issue Sep 13, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@hnryjms
Copy link
Member

hnryjms commented Sep 13, 2020

With the UI in #2 complete, we replaced the "arrived at 4:21pm" text with a less useful "synchronized" text which doesn't reflect any state of the member in your party. We should add a new Date() property on the Friend when they join, and display the time that person joined.
@hnryjms hnryjms added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 13, 2020
@WPRobson
Copy link
Contributor

WPRobson commented Jan 9, 2021

Opened #16 for this issue :)

hnryjms added a commit that referenced this issue Mar 31, 2022
@hnryjms
Merge pull request #16 from WPRobson/master
0add70a 
#9 Change to display time at which a friend joined the session
@WPRobson
Copy link
Contributor

WPRobson commented Apr 1, 2022

@hnryjms I guess we can close this now? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hnryjms @WPRobson