Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Infinite Video Scanning (after session gives up) #12

Open
hnryjms opened this issue Sep 13, 2020 · 0 comments · May be fixed by #26
Open

UI: Infinite Video Scanning (after session gives up) #12

hnryjms opened this issue Sep 13, 2020 · 0 comments · May be fixed by #26
Labels
bug Something isn't working

Comments

@hnryjms
Copy link
Member

hnryjms commented Sep 13, 2020

Right now, the video detect code will scan for a video 10 seconds, and then give up without reporting any status back to the background process (to then be reported to the popup UI). This is the case because right now, the port is not open until the video is detected, and Host.js treats any name: session port as a successful video discovery (which then will prompt the UI to move to the Ready state).

We need to either prevent the frame->background (SessionPort) from being assumed as a video discovery event, or we need to use some other notification system to show that no video has been detected. Preferably, we would wait until every frame is done scanning for a video.

We also should add logic that prevents multiple parallel scans for a video from occurring within a single frame/tab at once.

@hnryjms hnryjms added the bug Something isn't working label Sep 13, 2020
@wmww wmww linked a pull request Jan 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant